User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Build ID: 20160803113201

* integer mult + div -> integer result. USECS_PER_S ensures that the result isn't decimal (at least negligible) * 'usPerFrame' is converted back to uint64_t by FromMicroseconds() anyway * CID 1368390

* integer mult + div -> integer result. USECS_PER_S ensures that the result isn't decimal (at least negligible) * 'usPerFrame' is converted back to uint64_t by FromMicroseconds() anyway * CID 1368390

Comment on attachment 8789752 [details] [diff] [review] fixed - Fix a unit issue in ADTSDemuxer. r="jyavenard" Review of attachment 8789752 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/ADTSDemuxer.cpp @@ +613,5 @@ > if (!mSamplesPerSecond) { > return media::TimeUnit::FromMicroseconds(-1); > } > > + const uint32_t usPerFrame = USECS_PER_S * mSamplesPerFrame / mSamplesPerSecond; this is too inaccurate. you're now rounding before the final result keep it a double, just cast USECS_PER_S to double.

if you do believe that using integer is fine. Then use TimeUnit all the way and FramesToTimeUnit utility from VideoUtils.h e.g. TimeUnit frameDuration = FramesToTimeUnit(mSamplesPerFrame, mSamplesPerSecond); return frameDuration * aNumFrames; Actually, return FramesToTimeUnit(aNumFrames * mSamplesPerFrame, mSamplesPerSeconds); is probably the best approach.

* Simplified and factored computation by using FramesToTimeUnit() * CID 1368390

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ca5e5bbcf2d Fix a unit issue in ADTSDemuxer. r=jya